Back out "feat(caches): support opting into or out of specific name c… #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context I should have held off landing this as I ended up deciding that it was better to have well defined caches that need to be opted into explicitly. I want to avoid having a release with this regex feature to ensure we don't have users accidentally using it and then needing to stop using it on the next release. |
jcristau
approved these changes
Jan 15, 2025
…aches" This backs out commit a70a57c. For context I should have held off landing this as I ended up deciding that it was better to have well defined caches that need to be opted into explicitly. I want to avoid having a release with this regex feature to ensure we don't have users accidentally using it and then needing to stop using it on the next release.
ahal
force-pushed
the
ahal/push-romwuotwlvlm
branch
from
5d4f050 to
7b18977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aches"
This backs out commit a70a57c.