diff: exit 2 in case we find differences #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's currently no way for consumers to differentiate between "there was an error generating the diff" and "there were differences", since both exit 1. Unfortunately this is reversed from the diff command, which exits "0 if the inputs are the same, 1 if different, 2 if trouble", but given python's behavior I'm not sure we can reliably do better.
jcristau
added a commit
to jcristau/fxci-config
that referenced
this pull request
Dec 19, 2024
First release with taskcluster/tc-admin#278
jcristau
added a commit
to jcristau/fxci-config
that referenced
this pull request
Dec 20, 2024
First release with taskcluster/tc-admin#278
bhearsum
added a commit
to mozilla-releng/fxci-config
that referenced
this pull request
Jan 6, 2025
* Require tc-admin 4.0.2 First release with taskcluster/tc-admin#278 * ci: check `tc-admin diff` exit code Avoid optimizing out all tasks when the diff fails. --------- Co-authored-by: Ben Hearsum (he/him) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no way for consumers to differentiate between "there was an error generating the diff" and "there were differences", since both exit 1.
Unfortunately this is reversed from the diff command, which exits "0 if the inputs are the same, 1 if different, 2 if trouble", but given python's behavior I'm not sure we can reliably do better.