Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

[Deprecation of objects] Ember 2.0 on extending Service #40

Closed
wants to merge 1 commit into from
Closed

[Deprecation of objects] Ember 2.0 on extending Service #40

wants to merge 1 commit into from

Conversation

anvyst
Copy link

@anvyst anvyst commented Aug 9, 2016 •
edited
Loading

Hey,

Running the addon on my 2.7.x installation of Ember, noticed couple of deprecation messages on usage of Ember.Service.extend, instead of Ember.Object.extend in service, and one variable application in the initializer.

Reference: services can no longer extend Ember.Object

@locks locks mentioned this pull request Aug 18, 2016
Closed
@locks
Copy link
Contributor

locks commented Aug 18, 2016

@anvyst hi, can you rebase?

@locks
Copy link
Contributor

locks commented Aug 18, 2016

We discussed off-thread that I noticed #36 also changes how the services are injected which interests me, so I'll try to pull in those changes instead.
Thanks for the contribution @anvyst!

@locks locks closed this Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anvyst @locks