Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgrade guide #1340

Merged
merged 9 commits into from
Aug 10, 2023
Merged

feat: add upgrade guide #1340

merged 9 commits into from
Aug 10, 2023

Conversation

lucasfernog
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for tauri-docs-starlight ready!

Name Link
🔨 Latest commit b30d783
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/64d492233c692f0008480f11
😎 Deploy Preview https://deploy-preview-1340--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucasfernog
Copy link
Member Author

Includes some changes not yet available but I wanted to get this out ASAP. Also the guide assumes v2 stable is already out and the install instructions does not take the alpha in consideration.

@lorenzolewis
Copy link
Member

Oh this is amazing! I'll take a look at it later this week and do a copy pass

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Lorenzo Lewis <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
Signed-off-by: Lorenzo Lewis <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
Signed-off-by: Lorenzo Lewis <[email protected]>
@lorenzolewis
Copy link
Member

Started working on this one. Overall love the detail, just trying to group the information a bit more and make it easy to link to specific migration sections.

Could you take a look at this one I reworked and let me know if it's okay: https://deploy-preview-1340--tauri-docs-starlight.netlify.app/2/guide/upgrade-migrate/from-tauri-1/#migrate-to-cli-plugin

I'll wait for feedback before I de-dup and re-work the sections below that.

@FabianLars @simonhyll any feedback on any improvements we could make to make migration easier?

@FabianLars
Copy link
Member

FabianLars simonhyll any feedback on any improvements we could make to make migration easier?

Not yet, nope. Looks good so far :)

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: Lorenzo Lewis <[email protected]>
Copy link
Member

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking a while on this one, it was a long (but very good) one. Put in a few comments just to fill in a few missing pieces and then I think should be good to merge.

Excited on this one because we should be able to easily add to this for different scenarios as we get feedback for any rough spots.


### Migrate to App Plugin

{/* TODO: Is the Tauri 1.0 Rust equivalent something like tauri::window::Window::hide? */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Tauri 1.0 Rust equivalent something like tauri::window::Window::hide (so we can list it here like the rest of the migration sections).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rust equivalent wasn't changed.

</TabItem>
<TabItem label="Rust">

{/* TODO: Rust example */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example for this one?

</TabItem>
<TabItem label="Rust">

{/* TODO: Code example of this one? */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example for this one? This one only initialises the plugin

</TabItem>
<TabItem label="Rust">

{/* TODO: Code example on the Rust side */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example for this one?

</TabItem>
<TabItem label="Rust">

{/* TODO: Rust example */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example for this one?

</TabItem>
<TabItem label="Rust">

{/* TODO: Rust example */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example for this one? Should I copy-paste from the shell example?

</TabItem>
<TabItem label="Rust">

{/* TODO: Does this one need to be this complicated or could we simplify it to be similar to the other Rust code blocks? */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this example be simplified to cover the most common use case or best example? Or is this a more involved migration that we need to keep this in on?

</TabItem>
<TabItem label="Rust">

{/* TODO: Rust example */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example for this one?

Copy link
Member

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely amazing! Thank you @lucasfernog

I just tweaked the overall page to be called "Upgrading", but still referring to some of actions (like moving towards a plugin) a "migration". Potato/potato, but upgrading felt like the more appropriate word for the overall guide to me.

@lorenzolewis lorenzolewis merged commit 1664cd1 into next Aug 10, 2023
@lorenzolewis lorenzolewis deleted the feat/upgrade-guide branch August 10, 2023 07:35
simonhyll pushed a commit to simonhyll/tauri-docs that referenced this pull request Aug 10, 2023
* feat: add upgrade guide

* update paragraph

Signed-off-by: Lorenzo Lewis <[email protected]>

* lots of updates

Signed-off-by: Lorenzo Lewis <[email protected]>

* refactors

Signed-off-by: Lorenzo Lewis <[email protected]>

* add link to migrate cli command

Signed-off-by: Lorenzo Lewis <[email protected]>

* add examples

* change high-level phrasing to upgrade

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Lorenzo Lewis <[email protected]>
simonhyll pushed a commit to simonhyll/tauri-docs that referenced this pull request Aug 10, 2023
* feat: add upgrade guide

* update paragraph

Signed-off-by: Lorenzo Lewis <[email protected]>

* lots of updates

Signed-off-by: Lorenzo Lewis <[email protected]>

* refactors

Signed-off-by: Lorenzo Lewis <[email protected]>

* add link to migrate cli command

Signed-off-by: Lorenzo Lewis <[email protected]>

* add examples

* change high-level phrasing to upgrade

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Lorenzo Lewis <[email protected]>
simonhyll pushed a commit to simonhyll/tauri-docs that referenced this pull request Aug 10, 2023
* feat: add upgrade guide

* update paragraph

Signed-off-by: Lorenzo Lewis <[email protected]>

* lots of updates

Signed-off-by: Lorenzo Lewis <[email protected]>

* refactors

Signed-off-by: Lorenzo Lewis <[email protected]>

* add link to migrate cli command

Signed-off-by: Lorenzo Lewis <[email protected]>

* add examples

* change high-level phrasing to upgrade

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Lorenzo Lewis <[email protected]>
simonhyll pushed a commit to simonhyll/tauri-docs that referenced this pull request Aug 10, 2023
* feat: add upgrade guide

* update paragraph

Signed-off-by: Lorenzo Lewis <[email protected]>

* lots of updates

Signed-off-by: Lorenzo Lewis <[email protected]>

* refactors

Signed-off-by: Lorenzo Lewis <[email protected]>

* add link to migrate cli command

Signed-off-by: Lorenzo Lewis <[email protected]>

* add examples

* change high-level phrasing to upgrade

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Lorenzo Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants