Feat/i18n #607
Merged
Feat/i18n #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tauri ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
-- Don't merge -- |
|
Here are the test deploy logs showing successful authentication and dry runs for crowding: https://app.netlify.com/sites/tauri/deploys/6299ef3b62286600082b039b Going to change the netlify config to now only run this in the production context |
|
Awesome! Do we want to merge it right or would that send the wrong message? |
|
imo we should merge it relatively asap, but without advertising it (for now). Just so that we can make sure everything works |
|
It's good to merge now. |
FabianLars
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ready to turn on the fancy i18n (insert random emoji here).
Note: This is currently not going to upload any of the files in the
docsfolder; it will only be some default Docusaurus strings and anything in thepagesfolder that properly has the translation elements woven in. Additional docs will be enabled for translation in their respective PRs as I'd like to use this to only enable i18n, not necessarily populate everything at once.Deploy logs of a dry-run test on this branch: https://app.netlify.com/sites/tauri/deploys/6299ef3b62286600082b039b