-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file association support, closes #3736 #4320
Conversation
291d764
to
dc02143
Compare
821d383
to
54b05cb
Compare
@lucasfernog Would you take a look at this? |
Thanks for the PR @meowtec I'll take a look as soon as we're ready to start merging new features. |
54b05cb
to
f6a04cf
Compare
We require all commits to be signed across Tauri's repositories. So while we wait for a plan on how we want to handle features going forward, you can use the time to sign your commits. Follow this guide to s set up commit signing. |
e2d0a7a
to
9a3740a
Compare
@JonasKruckenberg I have signed theme. Is there something incorrect? |
9a3740a
to
e7af0c2
Compare
e7af0c2
to
ef8b8dc
Compare
Update: This change shoud be compatible with deep-link (#323), and here is the demo code for macOS: https://github.com/meowtec/tauri/tree/feat/deep-link-mac:
|
@meowtec imo it would be fine to let this PR focus on the file associations, but if you want to do it anyway, i have working implementations for Linux and Windows here: https://github.com/FabianLars/tauri-plugin-deep-link (Just the Edit: I planned on splitting that repo into 2 crates, one just for registering the protocols. Would that help you here? |
It looks better to make both file associations and deep-link PRs separated. |
025ccfc
to
1ffaf70
Compare
This is now just waiting on tao 0.21 and wry 0.30. |
I just destroyed my VM testing some NSIS changes 🤡 |
I've removed the |
So.. did this make it in? I'm not seeing it in the tauri docs? Thanks! |
Hi @tnrich , I followed this question up here: #3736 (comment) |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
ref: #3736
Some apps like a picture viewer or a file editor would need a function that the user can right-click on a file and Open with the app.
In some systems such as windows, this comments (#918 (comment)) may work.
But in macOS, it is required to:
CFBundleDocumentTypes
to the plist file, otherwise we CAN NOT choose the app for opening file because the app is disabled in the Open With app list.NOTICE: this MR broken because some feature of tauri-apps/tao#422 is required