feat(build): Use embed-resource for windows resource compilation
#6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the minimal approach to this fix, by keeping @FabianLars suggested that we might want to change how this file is generated, maybe by mimicking the template mechanism used for WiX file. I'm open to explore this path if needed. |
`embed-resource` has a better compiler detection that `winres`, this improves the cross compilation support. Also remove the need for `winres` fork for the cross-compilation support.
Guiguiprim
force-pushed
the
gv/use-embed-resource
branch
from
9857eb6 to
6325731
Compare
|
This as been done elsewhere according to tauri-apps/winres#8 (comment) (And my initial bug is fixed in the last alpha) |
|
Yeah sorry for doing that behind your back! I wanted to fix cross-compilation for 1.3 at the last minute so i took a more drastic approach 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for resolving #6746
embed-resourcehas a better compiler detection thatwinres, this improves the cross compilation support.Also remove the need for
winresfork for the cross-compilation support.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
But it could by removing
tauri_build::WindowsAttributes::sdk_dir()if integrated in2.0.0, as is I only deprecated the API.Checklist
fix: remove a typo, closes #___, #___)Other information