Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down, move, up, cancel and hold events #101

Merged
merged 24 commits into from
Nov 21, 2014
+192 −141
Merged

Down, move, up, cancel and hold events #101

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1f732e3
Remove pointers from Interaction#pointers
taye Nov 14, 2014
f4b9ac6
Check allowResume in getInterac... not poitnerDown
taye Nov 14, 2014
55dadf4
Make tap event target collection code more general
taye Nov 14, 2014
03287b6
Move ending code from pointerUp to new pointerEnd
taye Nov 14, 2014
f4bd25c
Add Interaction#pointerCancel similar to pointerUp
taye Nov 14, 2014
95c24fa
Implement 'down', 'move', 'up', 'cancel' events
taye Nov 14, 2014
5fddf2e
Log down, move, up, cancel events in swipe demo
taye Nov 14, 2014
bc1e619
Do var console = window.console to please jshint
taye Nov 14, 2014
745ad07
Do collectTaps from pointerUp
taye Nov 14, 2014
9ff85a2
Reduce code duplication for firing tap events
taye Nov 14, 2014
4f5fe5e
Don't fire "move" event on duplicate pointer move
taye Nov 15, 2014
8cc42bb
Only collect interactables that have listeners
taye Nov 15, 2014
55cd72d
Add pointerId and pointerType to up, move, tap...
taye Nov 15, 2014
cb7ab75
Implement "hold" event
taye Nov 15, 2014
334c504
Log hold events in swipe demo
taye Nov 15, 2014
4493e7a
Fix typo that made double tap fire after doubletap
taye Nov 15, 2014
80738ba
Make move and hold consider pointerMoveTolerance
taye Nov 15, 2014
bc4d38b
Add interaction to pointer events (tap, move...)
taye Nov 15, 2014
c70dec1
Show more info in swipe demo
taye Nov 15, 2014
26a2709
Appease JSHint
taye Nov 15, 2014
818dd46
Improve simultaneous taps
taye Nov 15, 2014
681ac29
Change hold time to 600ms
taye Nov 19, 2014
71c9d80
Record/remove pointers from other listers
taye Nov 20, 2014
fb69ab6
Delete Interaction#holdTimer entries on pointer up
taye Nov 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appease JSHint
@taye
taye committed Nov 15, 2014
commit 26a2709f44f67d92b9792743e56554e344e92466
4 changes: 1 addition & 3 deletions interact.js
View file
Original file line number Diff line number Diff line change
@@ -1387,8 +1387,6 @@
return;
}

var that = this;

function pushMatches (interactable, selector, context) {
var elements = ie8MatchesSelector
? context.querySelectorAll(selector)
@@ -1843,7 +1841,7 @@
return gestureEvent;
},

pointerHold: function (pointer, event, eventTarget, curEventTarget) {
pointerHold: function (pointer, event, eventTarget) {
this.collectEventTargets(pointer, event, eventTarget, 'hold');
},