Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYE request misses Max-Forwards header #194

Closed
Suxsem opened this issue Dec 17, 2023 · 1 comment
Closed

BYE request misses Max-Forwards header #194

Suxsem opened this issue Dec 17, 2023 · 1 comment
Assignees
@tayler6000
Labels
bug Something isn't working

Comments

@Suxsem
Copy link

Suxsem commented Dec 17, 2023

Hi,
BYE request misses the "Max-Forwards: 70\r\n" header.
It is present for all other requests, I think it's a typo.

This causes 483 too many hops in some cases.

Thank you.
@tayler6000
Copy link
Owner

Thank you for this report, I'll get this fixed today!

@tayler6000 tayler6000 self-assigned this Jan 3, 2024
@tayler6000 tayler6000 added the bug Something isn't working label Jan 3, 2024
@tayler6000 tayler6000 added this to pyVoIP Jan 3, 2024
@github-project-automation github-project-automation bot moved this to Todo - Release in pyVoIP Jan 3, 2024
@tayler6000 tayler6000 moved this from Todo - Release to Todo - Patching in pyVoIP Jan 3, 2024
tayler6000 added a commit that referenced this issue Jan 3, 2024
@tayler6000
Merge pull request #200 from tayler6000/bugfix/Issue-194
1b59e70 
Fixes #194
@github-project-automation github-project-automation bot moved this from Todo - Patching to Done in pyVoIP Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tayler6000 tayler6000

Labels
bug Something isn't working
Projects
pyVoIP
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Suxsem @tayler6000