Fixes #55 #145
Merged
Fixes #55 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Changed socket out to be a reference to socket in for RTPClient.
Some systems were just replying to the port they were receiving RTP on
instead of sending RTP to the port specified in the SDP of the INVITE or
OK message. This was causing loss of audio and DTMF on those systems.
|
By chance I was experiencing this issue today with Twilio's hosted PBX and applied the same change, which fixed the issue for me. |
|
@ainscore Glad it helped! Just to make sure, you didn't open an GitHub Issue right? No need to if you didn't, but if you did, I want to make sure it gets linked here. |
|
Fixes #146 |
Right I do not have an open Github issue for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed socket out to be a reference to socket in for RTPClient.
Some systems were just replying to the port they were receiving RTP on instead of sending RTP to the port specified in the SDP of the INVITE or OK message. This was causing loss of audio and DTMF on those systems.
Waiting to hear if this fixed the issue, and if it does, will push an additional commit to release pyVoIP v1.6.5