Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests requiring gpu should xfail if gpu is not available #50

Closed
kyleaoman opened this issue Feb 19, 2024 · 1 comment
Closed

Tests requiring gpu should xfail if gpu is not available #50

kyleaoman opened this issue Feb 19, 2024 · 1 comment

Comments

@kyleaoman
Copy link

It would make sense for tests needing the gpu to be skipped or xfail if a gpu is not available.
@kyleaoman kyleaoman mentioned this issue Feb 20, 2024
Closed
tberlok added a commit that referenced this issue Feb 29, 2024
@tberlok
Skip GPU tests if cupy and numba not installed
0eba077 
See issue #50
@tberlok tberlok mentioned this issue Feb 29, 2024
Merged
@tberlok
Copy link
Owner

tberlok commented Mar 10, 2024

Good point. I have now implemented that they xfail.

@tberlok tberlok closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tberlok @kyleaoman