New test for Issue 1363 (Azure#1388)

* Added test for compile error when XML Doc comments CRef cannot be resolved

* Regenereted expected tests that were missed with fix for 1363

* Removed the specific test for Bug1363 since other CSharp unit test will cover the same scenarios

* fixed test name

* removed the unneeded xmlDocumenationStream.  This was causing a bad IL format in the combiled assembly.

src/dev/AutoRest.Tooling.CSharp.Compiler/Compilation/CSharpCompiler.cs

@@ -14,7 +14,7 @@ public class CSharpCompiler : ManagedCompiler
     {
         private static readonly CSharpParseOptions parseOptions = new CSharpParseOptions(
             LanguageVersion.CSharp6,
-            DocumentationMode.None);
+            DocumentationMode.Diagnose);
 
         public CSharpCompiler(IEnumerable<KeyValuePair<string, string>> sources,
             IEnumerable<string> referencesAsFilenames)

src/dev/TestServer/server/app.js

@@ -291,7 +291,7 @@ var coverage = {
   "UrlQueriesArrayCsvEmpty": 0,
   "UrlQueriesArrayCsvValid": 0,
   //Once all the languages implement this test, the scenario counter should be reset to zero. It is currently implemented in C#
-  "UrlQueriesArrayMultiCsvNull": 1,
+  "UrlQueriesArrayMultiNull": 1,
   "UrlQueriesArrayMultiEmpty": 1,
   "UrlQueriesArrayMultiValid": 1,
   "UrlQueriesArraySsvValid": 0,

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureBodyDuration/AutoRestDurationTestService.cs

@@ -118,7 +118,7 @@ protected AutoRestDurationTestService(System.Uri baseUri, params System.Net.Http
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestDurationTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -231,7 +231,7 @@ public AutoRestDurationTestService(System.Uri baseUri, Microsoft.Rest.ServiceCli
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestDurationTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureBodyDurationAllSync/AutoRestDurationTestService.cs

@@ -118,7 +118,7 @@ protected AutoRestDurationTestService(System.Uri baseUri, params System.Net.Http
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestDurationTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -231,7 +231,7 @@ public AutoRestDurationTestService(System.Uri baseUri, Microsoft.Rest.ServiceCli
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestDurationTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureBodyDurationNoSync/AutoRestDurationTestService.cs

@@ -118,7 +118,7 @@ protected AutoRestDurationTestService(System.Uri baseUri, params System.Net.Http
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestDurationTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -231,7 +231,7 @@ public AutoRestDurationTestService(System.Uri baseUri, Microsoft.Rest.ServiceCli
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestDurationTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureCompositeModelClient/AzureCompositeModel.cs

@@ -159,7 +159,7 @@ protected AzureCompositeModel(System.Uri baseUri, params System.Net.Http.Delegat
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AzureCompositeModel(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -272,7 +272,7 @@ public AzureCompositeModel(System.Uri baseUri, Microsoft.Rest.ServiceClientCrede
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AzureCompositeModel(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureParameterGrouping/AutoRestParameterGroupingTestService.cs

@@ -118,7 +118,7 @@ protected AutoRestParameterGroupingTestService(System.Uri baseUri, params System
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestParameterGroupingTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -231,7 +231,7 @@ public AutoRestParameterGroupingTestService(System.Uri baseUri, Microsoft.Rest.S
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestParameterGroupingTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureReport/AutoRestReportServiceForAzure.cs

@@ -113,7 +113,7 @@ protected AutoRestReportServiceForAzure(System.Uri baseUri, params System.Net.Ht
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestReportServiceForAzure(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -226,7 +226,7 @@ public AutoRestReportServiceForAzure(System.Uri baseUri, Microsoft.Rest.ServiceC
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestReportServiceForAzure(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureResource/AutoRestResourceFlatteningTestService.cs

@@ -113,7 +113,7 @@ protected AutoRestResourceFlatteningTestService(System.Uri baseUri, params Syste
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestResourceFlatteningTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -226,7 +226,7 @@ public AutoRestResourceFlatteningTestService(System.Uri baseUri, Microsoft.Rest.
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestResourceFlatteningTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/AzureSpecials/AutoRestAzureSpecialParametersTestClient.cs

@@ -165,7 +165,7 @@ protected AutoRestAzureSpecialParametersTestClient(System.Uri baseUri, params Sy
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestAzureSpecialParametersTestClient(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -278,7 +278,7 @@ public AutoRestAzureSpecialParametersTestClient(System.Uri baseUri, Microsoft.Re
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestAzureSpecialParametersTestClient(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/Head/AutoRestHeadTestService.cs

@@ -117,7 +117,7 @@ protected AutoRestHeadTestService(System.Uri baseUri, params System.Net.Http.Del
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestHeadTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -230,7 +230,7 @@ public AutoRestHeadTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientC
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestHeadTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/HeadExceptions/AutoRestHeadExceptionTestService.cs

@@ -117,7 +117,7 @@ protected AutoRestHeadExceptionTestService(System.Uri baseUri, params System.Net
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestHeadExceptionTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -230,7 +230,7 @@ public AutoRestHeadExceptionTestService(System.Uri baseUri, Microsoft.Rest.Servi
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestHeadExceptionTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/Lro/AutoRestLongRunningOperationTestService.cs

@@ -133,7 +133,7 @@ protected AutoRestLongRunningOperationTestService(System.Uri baseUri, params Sys
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestLongRunningOperationTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -246,7 +246,7 @@ public AutoRestLongRunningOperationTestService(System.Uri baseUri, Microsoft.Res
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestLongRunningOperationTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/Paging/AutoRestPagingTestService.cs

@@ -118,7 +118,7 @@ protected AutoRestPagingTestService(System.Uri baseUri, params System.Net.Http.D
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected AutoRestPagingTestService(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -231,7 +231,7 @@ public AutoRestPagingTestService(System.Uri baseUri, Microsoft.Rest.ServiceClien
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public AutoRestPagingTestService(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Azure.Tests/Expected/AcceptanceTests/SubscriptionIdApiVersion/MicrosoftAzureTestUrl.cs

@@ -128,7 +128,7 @@ protected MicrosoftAzureTestUrl(System.Uri baseUri, params System.Net.Http.Deleg
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         protected MicrosoftAzureTestUrl(System.Uri baseUri, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)
@@ -241,7 +241,7 @@ public MicrosoftAzureTestUrl(System.Uri baseUri, Microsoft.Rest.ServiceClientCre
         /// <param name='handlers'>
         /// Optional. The delegating handlers to add to the http client pipeline.
         /// </param>
-        /// <exception cref="ArgumentNullException">
+        /// <exception cref="System.ArgumentNullException">
         /// Thrown when a required parameter is null
         /// </exception>
         public MicrosoftAzureTestUrl(System.Uri baseUri, Microsoft.Rest.ServiceClientCredentials credentials, System.Net.Http.HttpClientHandler rootHandler, params System.Net.Http.DelegatingHandler[] handlers) : this(rootHandler, handlers)

src/generator/AutoRest.CSharp.Unit.Tests/BugTest.cs

@@ -20,8 +20,8 @@ namespace AutoRest.CSharp.Unit.Tests
     public class BugTest
     {
         private ITestOutputHelper _output;
-        internal static string[] SuppressWarnings = {"CS1701"};
-
+        internal static string[] SuppressWarnings = {"CS1701", "CS1591" };
+        //Todo: Remove CS1591 when issue https://github.com/Azure/autorest/issues/1387 is fixed
         public BugTest(ITestOutputHelper output)
         {
             _output = output;