Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: add missing ! on calls to OrdinaryObjectCreate #2098

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Editorial: add missing ! on calls to OrdinaryObjectCreate #2098

merged 1 commit into from
Sep 2, 2020

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 15, 2020

Fixes #2097.

@ljharb ljharb added editorial change completion records Relates to completion records, and ? / ! notation. labels Jul 15, 2020
@ljharb ljharb requested review from syg, michaelficarra, bakkot and a team July 15, 2020 16:29
@ljharb ljharb mentioned this pull request Jul 15, 2020
Closed
michaelficarra
michaelficarra approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate this.

@ljharb ljharb requested a review from a team September 2, 2020 21:49
@ljharb ljharb self-assigned this Sep 2, 2020
@ljharb ljharb merged commit 8e0e7d1 into tc39:master Sep 2, 2020
@ljharb ljharb deleted the missing-! branch September 2, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

@syg syg Awaiting requested review from syg

Assignees

@ljharb ljharb

Labels
completion records Relates to completion records, and ? / ! notation. editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editorial: Spec is inconsistent in checking the result of OrdinaryObjectCreate
3 participants
@ljharb @michaelficarra @bakkot