Editorial: Evaluation is user code by definition #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Nov 17, 2022
bakkot
added
the
ready to merge
ljharb
force-pushed
the
evaluation-is-user-code
branch
from
4f05706 to
632615b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ecmarkup currently special-cases the phrase "the result of evaluating" as invoking user code, but as of #2744 we barely use that terminology and instead invoke the Evaluation SDO. But we forgot to mark that SDO as invoking user code, despite that being definitionally what it is.
I recall discussing that we'd need to do this, but either I dreamt that or we forgot. Either way, whoops.