Remove @@iterator from Module Namespace objects #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per consensus at the November 2016 meeting, Module Namespace exotic objects no longer have an @@iterator method. Also changes the [[Configurable]] property of the @@toStringTag property to false, as per consensus in the same meeting (and because it's impossible to reconfigure due to the exotic methods of such objects). This closes tc39#693 and tc39#710.
|
LGTM |
ljharb
approved these changes
Dec 7, 2016
This was referenced Dec 24, 2016
|
Test262 collateral: tc39/test262#810, tc39/test262#811. |
|
There's still something odd about @@toStringTag, which is that deleting it returns true, although it has no effect. Deleting any other existing property returns false. To change this, I suggest the following steps to be inserted between steps 2 and 3 of https://tc39.github.io/ecma262/#sec-module-namespace-exotic-objects-delete-p.
(There's only one symbol but I'm just reusing existing language.) Or, alternatively:
|
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jan 4, 2017
See tc39/ecma262#747. [email protected] BUG=v8:1569 Review-Url: https://codereview.chromium.org/2603193002 Cr-Commit-Position: refs/heads/master@{#42057}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per consensus at the November 2016 meeting, Module Namespace exotic
objects no longer have an @@iterator method.
Also changes the [[Configurable]] property of the @@toStringTag
property to false, as per consensus in the same meeting (and
because it's impossible to reconfigure due to the exotic
methods of such objects).
This closes #693 and #710.