Accept options as 3rd parameter; Fix a spec bug that value might overflow #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
littledan
approved these changes
May 13, 2020
Jack-Works
commented
May 13, 2020
| @@ -3,7 +3,7 @@ | |||
| // This polyfill requires: globalThis, BigInt & private fields | |||
| ;(() => { | |||
| // Math.abs does not support BigInt. | |||
There was a problem hiding this comment.
Oh this. Math.abs doesn't support BigInt. Does there any solution or I have to write an abs function myself?
There was a problem hiding this comment.
There's no built-in function for this, but I think @ljharb was interested in a proposal to relax this restriction.
There was a problem hiding this comment.
I think all Math methods where it makes sense should accept all number types, yes.
There was a problem hiding this comment.
Oh, Math.sign should support bigint too. Is there a plan for it? @ljharb
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #25
{step?}Number.range(0, 5, 1.5)will emit6as final value(from, to]to[from, to)(the design is[from, to)currently, so it's a bug if you want to inclusive range please check Inclusive range #26)