Fix typo and broken links #2347
Conversation
| @@ -224,7 +224,7 @@ date.daysInYear; // => 365 | |||
|
|
|||
| ## 文字列による永続性 | |||
|
|
|||
| すべての`Temporal`タイプは、永続性や相互運用性のために文字列による表現を持っています。各タイプと文字列表現の対応を以下に示します。Temporal で使用されている ISO 8601 や RFC 3339 に関する、より詳細な情報と標準化に向けた取り組みに関しては[ECMAScript 拡張の ISO-8601 と RFC 3339](./strings.md)を参照してください。 | |||
| すべての`Temporal`タイプは、永続性や相互運用性のために文字列による表現を持っています。各タイプと文字列表現の対応を以下に示します。Temporal で使用されている ISO 8601 や RFC 3339 に関する、より詳細な情報と標準化に向けた取り組みに関しては[ECMAScript 拡張の ISO-8601 と RFC 3339](./iso-string-ext.md)を参照してください。 | |||
There was a problem hiding this comment.
Perhaps this could be the ../string.md which is the original English one. But I guess the translator intended to use ./iso-string-ext.md here. In the context of the translation, ./iso-string-ext.md seems to be fine to me. (I'm new to here so I'm not completely sure which one it should be though.)
There was a problem hiding this comment.
Either one is fine, I trust your judgement about what makes the most sense in this translation.
There was a problem hiding this comment.
iso-string-ext.md looks like it was the original filename of strings.md before I renamed it in #2059. So if we want to show the Japanese page (even if the content is somewhat out of date) then ./iso-string-ext.md is correct. If we want to link to the latest content, even though it's English, then I assume that we should use ../strings.md ?
There was a problem hiding this comment.
Ok, I just opened another PR #2353 to add a note to docs/ja about the latest content and leave the Japanese ./iso-string-ext.md page as it is.
Codecov Report
@@ Coverage Diff @@
## main #2347 +/- ##
==========================================
- Coverage 91.09% 81.76% -9.33%
==========================================
Files 19 17 -2
Lines 10573 10554 -19
Branches 1697 1480 -217
==========================================
- Hits 9631 8630 -1001
- Misses 932 1880 +948
- Partials 10 44 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fix broken links in
docs/jaand a minor typo fix indocs/zoneddatetime.md.