Update Temporal.Calendar docs #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust docs for Temporal.Calendar for a few reasons: * Account for #2574 which stops coercing non-string inputs * Fix inaccurate claims in the constructor docs * Reorganize sample code for `from` for clarity
Codecov Report
@@ Coverage Diff @@
## main #2634 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 20 20
Lines 11542 11542
Branches 2193 2193
=======================================
Hits 11074 11074
Misses 404 404
Partials 64 64 |
Ms2ger
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust docs for Temporal.Calendar for a few reasons:
fromfor clarity