Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for slots on maybe-undefined relativeTo #2659

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

justingrant
Copy link
Collaborator

Fixes #2618

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #2659 (c624b95) into main (c4f9cf7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2659   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          20       20           
  Lines       11604    11604           
  Branches     2196     2196           
=======================================
  Hits        11146    11146           
  Misses        394      394           
  Partials       64       64           

@justingrant justingrant merged commit 2920565 into tc39:main Aug 19, 2023
@ptomato
Copy link
Collaborator

ptomato commented Aug 22, 2023

I realized when rebasing that this was already solved in #2657. Sorry for the extra work!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 7, 2023
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 7, 2023
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 8, 2023
…p.round. r=sfink

Fixed in <tc39/proposal-temporal#2659>.

Differential Revision: https://phabricator.services.mozilla.com/D189783

UltraBlame original commit: 70af7f87744e66e7ac623c4fe246e41aad2c72e1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 8, 2023
…p.round. r=sfink

Fixed in <tc39/proposal-temporal#2659>.

Differential Revision: https://phabricator.services.mozilla.com/D189783

UltraBlame original commit: 70af7f87744e66e7ac623c4fe246e41aad2c72e1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 8, 2023
…p.round. r=sfink

Fixed in <tc39/proposal-temporal#2659>.

Differential Revision: https://phabricator.services.mozilla.com/D189783

UltraBlame original commit: 70af7f87744e66e7ac623c4fe246e41aad2c72e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporal.Duration.prototype.round: Test relativeTo is an object before checking internal slots
3 participants