Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Change overflow behaviour of PYM/PMD.toPlainDate #2718

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Normative: Change overflow behaviour of PYM/PMD.toPlainDate #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa2488
Normative: Change overflow behaviour of PYM/PMD.toPlainDate
ptomato Nov 3, 2023
724dfb6
Update test262
ptomato Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polyfill/lib/plainmonthday.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class PlainMonthDay {
const concatenatedFieldNames = ES.Call(ArrayPrototypeConcat, receiverFieldNames, inputFieldNames);
mergedFields = ES.PrepareTemporalFields(mergedFields, concatenatedFieldNames, [], [], 'ignore');
const options = ObjectCreate(null);
options.overflow = 'reject';
options.overflow = 'constrain';
return ES.CalendarDateFromFields(calendarRec, mergedFields, options);
}
getISOFields() {
Expand Down
2 changes: 1 addition & 1 deletion polyfill/lib/plainyearmonth.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export class PlainYearMonth {
const concatenatedFieldNames = ES.Call(ArrayPrototypeConcat, receiverFieldNames, inputFieldNames);
mergedFields = ES.PrepareTemporalFields(mergedFields, concatenatedFieldNames, [], [], 'ignore');
const options = ObjectCreate(null);
options.overflow = 'reject';
options.overflow = 'constrain';
return ES.CalendarDateFromFields(calendarRec, mergedFields, options);
}
getISOFields() {
Expand Down
2 changes: 1 addition & 1 deletion polyfill/test262
Open in desktop
Submodule test262 updated 38 files
+4 −5 features.txt
+2 −2 test/built-ins/Atomics/isLockFree/descriptor.js
+1 −1 test/built-ins/Set/prototype/union/add-not-called.js
+1 −1 test/built-ins/Set/prototype/union/allows-set-like-class.js
+1 −1 test/built-ins/Set/prototype/union/allows-set-like-object.js
+1 −1 test/built-ins/Set/prototype/union/appends-new-values.js
+1 −1 test/built-ins/Set/prototype/union/array-throws.js
+1 −1 test/built-ins/Set/prototype/union/builtins.js
+1 −1 test/built-ins/Set/prototype/union/called-with-object.js
+1 −1 test/built-ins/Set/prototype/union/combines-Map.js
+1 −1 test/built-ins/Set/prototype/union/combines-empty-sets.js
+1 −1 test/built-ins/Set/prototype/union/combines-itself.js
+1 −1 test/built-ins/Set/prototype/union/combines-same-sets.js
+1 −1 test/built-ins/Set/prototype/union/combines-sets.js
+1 −1 test/built-ins/Set/prototype/union/converts-negative-zero.js
+1 −1 test/built-ins/Set/prototype/union/has-is-callable.js
+1 −1 test/built-ins/Set/prototype/union/keys-is-callable.js
+1 −1 test/built-ins/Set/prototype/union/length.js
+1 −1 test/built-ins/Set/prototype/union/name.js
+1 −1 test/built-ins/Set/prototype/union/not-a-constructor.js
+1 −1 test/built-ins/Set/prototype/union/receiver-not-set.js
+1 −1 test/built-ins/Set/prototype/union/require-internal-slot.js
+1 −1 test/built-ins/Set/prototype/union/set-like-array.js
+1 −1 test/built-ins/Set/prototype/union/set-like-class-mutation.js
+1 −1 test/built-ins/Set/prototype/union/set-like-class-order.js
+1 −1 test/built-ins/Set/prototype/union/size-is-a-number.js
+1 −1 test/built-ins/Set/prototype/union/subclass-receiver-methods.js
+1 −1 test/built-ins/Set/prototype/union/subclass-symbol-species.js
+1 −1 test/built-ins/Set/prototype/union/subclass.js
+1 −1 test/built-ins/Set/prototype/union/union-properties.js
+0 −1 test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/basic.js
+14 −0 test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/default-overflow-behaviour.js
+19 −0 test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/default-overflow-behaviour.js
+3 −1 test/language/expressions/postfix-decrement/target-cover-id.js
+3 −1 test/language/expressions/postfix-increment/target-cover-id.js
+24 −0 test/staging/set-is-subset-on-set-like.js
+25 −0 test/staging/set-is-subset-table-receiver-cleared.js
+29 −0 test/staging/set-is-subset-table-transition.js
2 changes: 1 addition & 1 deletion spec/plainmonthday.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ <h1>Temporal.PlainMonthDay.prototype.toPlainDate ( _item_ )</h1>
1. Let _concatenatedFieldNames_ be the list-concatenation of _receiverFieldNames_ and _inputFieldNames_.
1. Set _mergedFields_ to ? PrepareTemporalFields(_mergedFields_, _concatenatedFieldNames_, «», «», ~ignore~).
1. Let _options_ be OrdinaryObjectCreate(*null*).
1. Perform ! CreateDataPropertyOrThrow(_options_, *"overflow"*, *"reject"*).
1. Perform ! CreateDataPropertyOrThrow(_options_, *"overflow"*, *"constrain"*).
1. Return ? CalendarDateFromFields(_calendarRec_, _mergedFields_, _options_).
</emu-alg>
</emu-clause>
Expand Down
2 changes: 1 addition & 1 deletion spec/plainyearmonth.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ <h1>Temporal.PlainYearMonth.prototype.toPlainDate ( _item_ )</h1>
1. Let _concatenatedFieldNames_ be the list-concatenation of _receiverFieldNames_ and _inputFieldNames_.
1. Set _mergedFields_ to ? PrepareTemporalFields(_mergedFields_, _concatenatedFieldNames_, «», «», ~ignore~).
1. Let _options_ be OrdinaryObjectCreate(*null*).
1. Perform ! CreateDataPropertyOrThrow(_options_, *"overflow"*, *"reject"*).
1. Perform ! CreateDataPropertyOrThrow(_options_, *"overflow"*, *"constrain"*).
1. Return ? CalendarDateFromFields(_calendarRec_, _mergedFields_, _options_).
</emu-alg>
</emu-clause>
Expand Down