Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Fix date difference for end-of-month edge cases #2759

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Normative: Fix date difference for end-of-month edge cases #2759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c544720
Normative: Fix date difference for end-of-month edge cases
ptomato Jan 27, 2024
74f3dbb
Update test262
ptomato Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions polyfill/lib/ecmascript.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3708,8 +3708,7 @@ export function RejectDuration(y, mon, w, d, h, min, s, ms, µs, ns) {
}

function ISODateSurpasses(sign, y1, m1, d1, y2, m2, d2) {
const constrained = ConstrainISODate(y1, m1, d1);
const cmp = CompareISODate(constrained.year, constrained.month, constrained.day, y2, m2, d2);
const cmp = CompareISODate(y1, m1, d1, y2, m2, d2);
return sign * cmp === 1;
}

Expand Down
2 changes: 1 addition & 1 deletion polyfill/test262
Open in desktop
Submodule test262 updated 9 files
+117 −0 test/built-ins/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month.js
+5 −5 test/built-ins/Temporal/PlainDate/prototype/until/largestunit-higher-units.js
+117 −0 test/built-ins/Temporal/PlainDate/prototype/until/wrapping-at-end-of-month.js
+117 −0 test/built-ins/Temporal/PlainDateTime/prototype/since/wrapping-at-end-of-month.js
+4 −4 test/built-ins/Temporal/PlainDateTime/prototype/until/no-unnecessary-units.js
+117 −0 test/built-ins/Temporal/PlainDateTime/prototype/until/wrapping-at-end-of-month.js
+117 −0 test/built-ins/Temporal/ZonedDateTime/prototype/since/wrapping-at-end-of-month.js
+117 −0 test/built-ins/Temporal/ZonedDateTime/prototype/until/wrapping-at-end-of-month.js
+28 −0 test/staging/built-ins/Array/prototype/flatMap/callback-with-side-effects.js
3 changes: 1 addition & 2 deletions spec/plaindate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,8 +799,7 @@ <h1>
</dd>
</dl>
<emu-alg>
1. Let _constrained_ be ! RegulateISODate(_y1_, _m1_, _d1_, *"constrain"*).
1. Let _comparison_ be CompareISODate(_constrained_.[[Year]], _constrained_.[[Month]], _constrained_.[[Day]], _y2_, _m2_, _d2_).
1. Let _comparison_ be CompareISODate(_y1_, _m1_, _d1_, _y2_, _m2_, _d2_).
1. If _sign_ &times; _comparison_ is 1, return *true*.
1. Return *false*.
</emu-alg>
Expand Down
Loading