Fix Test262 on MacOS / Node14 #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tc39#687 which prevented Test262 tests from running in my MacOS/Node14 environment. - if MacOS, use sysctl instead of nproc in ci_test.sh - defend against undefined `globalThis.__coverage__`
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 17 17
Lines 4780 4780
Branches 757 757
=======================================
Hits 4513 4513
Misses 264 264
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #687 which prevented Test262 tests from running in my MacOS/Node14 environment.
sysctl -n hw.logicalcpuinstead ofnprocinci_test.shglobalThis.__coverage__