-
Notifications
You must be signed in to change notification settings - Fork 480
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add templated tests for new proposed Annex B semantics
These tests are againt a proposed fix for tc39/ecma262#753 They seem to pass in V8, JSC and SpiderMonkey, though ChakraCore hews slightly closer to the previous specification.
- Loading branch information
Showing
4 changed files
with
151 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
src/annex-b-fns/eval-global-existing-non-enumerable-global-init.case
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Copyright (C) 2017 Igalia, S. L. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
desc: > | ||
Variable binding is left in place by legacy function hoisting. | ||
CreateGlobalVariableBinding leaves the binding as non-enumerable even | ||
if it has the chance to change it to be enumerable. | ||
template: eval-global | ||
info: | | ||
B.3.3.3 Changes to EvalDeclarationInstantiation | ||
|
||
[...] | ||
i. If varEnvRec is a global Environment Record, then | ||
i. Perform ? varEnvRec.CreateGlobalVarBinding(F, true). | ||
[...] | ||
|
||
includes: [fnGlobalObject.js, propertyHelper.js] | ||
---*/ | ||
|
||
//- setup | ||
Object.defineProperty(fnGlobalObject(), 'f', { | ||
value: 'x', | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}); | ||
//- before | ||
var global = fnGlobalObject(); | ||
assert.sameValue(f, 'x', "binding is not reinitialized"); | ||
|
||
verifyProperty(global, 'f', { | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}, { restore: true }); | ||
//- teardown | ||
assert.sameValue(typeof f, "function"); | ||
verifyProperty(global, 'f', { | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// Copyright (C) 2017 Igalia, S. L. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
desc: > | ||
Variable binding is left in place by legacy function hoisting. | ||
CreateGlobalVariableBinding leaves the binding as non-enumerable even | ||
if it has the chance to change it to be enumerable. | ||
template: global | ||
info: | | ||
B.3.3.3 Changes to GlobalDeclarationInstantiation | ||
|
||
[...] | ||
Perform ? varEnvRec.CreateGlobalVarBinding(F, true). | ||
[...] | ||
|
||
includes: [fnGlobalObject.js, propertyHelper.js] | ||
---*/ | ||
|
||
//- setup | ||
var global = fnGlobalObject(); | ||
Object.defineProperty(global, 'f', { | ||
value: 'x', | ||
enumerable: true, | ||
writable: true, | ||
configurable: false | ||
}); | ||
|
||
$262.evalScript(` | ||
assert.sameValue(f, 'x'); | ||
verifyProperty(global, 'f', { | ||
enumerable: true, | ||
writable: true, | ||
configurable: false | ||
}, { restore: true }); | ||
`); | ||
|
||
$262.evalScript(` | ||
//- body | ||
return 'inner declaration'; | ||
//- teardown | ||
`); | ||
|
||
$262.evalScript(` | ||
verifyProperty(global, 'f', { | ||
enumerable: true, | ||
writable: true, | ||
configurable: false | ||
}); | ||
`); |
50 changes: 50 additions & 0 deletions
50
src/annex-b-fns/global-existing-non-enumerable-global-init.case
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright (C) 2017 Igalia, S. L. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
/*--- | ||
desc: > | ||
Variable binding is left in place by legacy function hoisting. | ||
CreateGlobalVariableBinding leaves the binding as non-enumerable even | ||
if it has the chance to change it to be enumerable. | ||
template: global | ||
info: | | ||
B.3.3.3 Changes to GlobalDeclarationInstantiation | ||
|
||
[...] | ||
Perform ? varEnvRec.CreateGlobalVarBinding(F, true). | ||
[...] | ||
|
||
includes: [fnGlobalObject.js, propertyHelper.js] | ||
---*/ | ||
|
||
//- setup | ||
var global = fnGlobalObject(); | ||
Object.defineProperty(global, 'f', { | ||
value: 'x', | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}); | ||
|
||
$262.evalScript(` | ||
assert.sameValue(f, 'x'); | ||
verifyProperty(global, 'f', { | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}, { restore: true }); | ||
`); | ||
|
||
$262.evalScript(` | ||
//- body | ||
return 'inner declaration'; | ||
//- teardown | ||
`); | ||
|
||
$262.evalScript(` | ||
assert.sameValue(f(), 'inner declaration'); | ||
verifyProperty(global, 'f', { | ||
enumerable: false, | ||
writable: true, | ||
configurable: true | ||
}); | ||
`); |