Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests for BigInt.prototype.toString #1272

Merged
merged 2 commits into from
Oct 13, 2017
Merged

Updated tests for BigInt.prototype.toString #1272

merged 2 commits into from
Oct 13, 2017

Conversation

leobalter
Copy link
Member

Replaces #1244

Applying fixes for #1244, the original commit is preserved.

@leobalter
Copy link
Member Author

Not covered in this PR:

  1. this value capturing objects with an [[BigIntData]] internal. (e.g.: BigInt.prototype.toString.call(Object(1n))).
  2. ToInteger coercions and abrupt completions from radix.
  3. Observable variants for the same this value using different radix, as long as the implementation defined spec permits.

@rwaldron rwaldron merged commit 56e0261 into tc39:master Oct 13, 2017
@rwaldron
Copy link
Contributor

Not covered in this PR:

@leobalter Can you open a new issue with this list? Thanks!

@leobalter leobalter deleted the cxielarko-bigint-tostring branch October 13, 2017 18:04
@leobalter leobalter mentioned this pull request Oct 13, 2017
Closed
@leobalter
Copy link
Member Author

done #1275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leobalter @rwaldron