Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide session verification banner when there is only one session #180

Closed
2 tasks
giomfo opened this issue Aug 27, 2021 · 2 comments
Closed
2 tasks

Hide session verification banner when there is only one session #180

giomfo opened this issue Aug 27, 2021 · 2 comments
Assignees
Labels
android blocked to estimate the task should be estimated before being planned

Comments

@giomfo
Copy link
Contributor

giomfo commented Aug 27, 2021

  • If the client is aware that there is no other session for the current user the message of the following banner should not talk about "session"
    image

I suggest limiting the message of this dialog to "Verify your session to unlock your history".
The Element dev team decided to display this banner (even if there is no session) to let the user provide the secret phrase or the recovery key (if any). Talking about other sessions here is strange for the user point of view.

The wording of this banner should be simplified to avoid the inconsistency in this case and maybe others. I suggest keeping it as much short as possible to let the details come in the second screen.

  • The verification banner must not be displayed if the client is aware there is no backup available for the current user, and no other session too
@giomfo giomfo added to estimate the task should be estimated before being planned android labels Aug 27, 2021
@giomfo giomfo changed the title Hide session verification when there is only one session Hide session verification dialog when there is only one session Aug 27, 2021
@giomfo giomfo changed the title Hide session verification dialog when there is only one session Hide session verification banner when there is only one session Aug 27, 2021
@giomfo
Copy link
Contributor Author

giomfo commented Sep 10, 2021

This change should take place directly in Element-Android, we will sync about with the application team (see element-hq/element-android#3999)

@giomfo giomfo assigned giomfo and unassigned yostyle Nov 30, 2021
@giomfo giomfo added the blocked label May 3, 2022
@giomfo
Copy link
Contributor Author

giomfo commented May 3, 2022

wait for a feedback from Element crypto team

@giomfo giomfo closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android blocked to estimate the task should be estimated before being planned
Projects
None yet
Development

No branches or pull requests

2 participants