Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the session verification banner to handle correctly the case where there is only one session #3999

Closed
2 tasks
giomfo opened this issue Sep 10, 2021 · 2 comments
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Sep 10, 2021

Your use case

  • If the client is aware that there is no other session for the current user the message of the following banner should not talk about "session"
    image

I suggest limiting the message of this dialog to "Confirm your identity to unlock your history".
The Element dev team decided to display this banner (even if there is no session) to let the user provide the secret phrase or the recovery key (if any). Talking about other sessions here is strange for the user point of view.

The wording of this banner should be simplified to avoid the inconsistency in this case and maybe others. I suggest keeping it as much short as possible to let the details come in the second screen.

  • The verification banner must not be displayed if the client is aware there is no secure storage (backup) available for the current user, and no other session too

Have you considered any alternatives?

No response

Additional context

No response

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 10, 2021
@BillCarsonFr BillCarsonFr self-assigned this Jan 25, 2022
@giomfo
Copy link
Member Author

giomfo commented May 3, 2022

@BillCarsonFr Hi do you think this point is still a pending issue?
Can you please provide an update on it?

@BillCarsonFr
Copy link
Member

Fixed by #6475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

2 participants