feat: Enable email notifications for all servers #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estellecomment
changed the title
MarcWadai
reviewed
Mar 25, 2024
src/tchap/util/TchapUIFeature.ts
Outdated
Comment on lines
46
to
48
| if (homeserversWithFeature.length === 1 && homeserversWithFeature[0] === "*") { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Peut être ajouter en commentaire que le check du size 1 permet d'ignorer l'étoile s'il y a d'autre homeservers (merci les tests unitaires qui m'ont permit de comprendre pourquoi ! haha)
MarcWadai
reviewed
Mar 25, 2024
|
Trop bien le teeest et la nouvelle feature de pouvoir mettre l'étoile, bravoo ! 🎊 |
estellecomment
force-pushed
the
email-notifications-for-all
branch
from
1424ac8 to
f2ad846
Compare
estellecomment
force-pushed
the
email-notifications-for-all
branch
from
f2ad846 to
797a272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#940
Also adding to TchapFeatures :
["*"]means all servers (avoids listing them all, cluttering the config file and forgetting some in the list)