Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added body option #55

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Added body option #55

merged 1 commit into from
Jan 11, 2017

Conversation

jeppefrandsen
Copy link
Contributor

Added -b option for describing a release

@tcnksm
Copy link
Owner

tcnksm commented Jan 11, 2017

Thanks !

@tcnksm tcnksm merged commit e1d9cb3 into tcnksm:master Jan 11, 2017
@jeppefrandsen
Copy link
Contributor Author

Thank you! Can you create a new release with the changes?

@tcnksm
Copy link
Owner

tcnksm commented Jan 11, 2017

Done to release https://github.com/tcnksm/ghr/releases/tag/v0.5.4
Please test it !

@jeppefrandsen
Copy link
Contributor Author

Sorry for the late reply! Working great - thanks

@jeppefrandsen
Copy link
Contributor Author

Would it BTW be ok to set Name = TagName when creating the release (also done in their example: https://developer.github.com/v3/repos/releases/). Sometimes we see that the heading is also including the PR name. Thanks

@tcnksm
Copy link
Owner

tcnksm commented Jan 14, 2017

@jeppefrandsen yeah, it would be nice! I will work when I have time. But if you can, please PR!

@jeppefrandsen
Copy link
Contributor Author

Will do. Change is a one-liner. But will test on our repositories to make sure it is fixed before doing a PR. Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants