Fix "maximum call stack size exceeded" when there are many errors #363
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osi-jehrlich
changed the title
|
Is there anything else needed or is there anything I can do to help move this along? |
|
Yeah this looks reasonable. I vaguely recall there was a reason we avoided |
|
@osi-jehrlich Landed in 1.4.1, please take a look and report how that works. |
|
Will do, thank you! |
|
Things are looking good so far. I'll let you know or submit a PR if anything comes up. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344.
Note: The included test simulates one million errors. To keep the tests running fast it does so using a custom keyword to produce all of the errors. This approach was over 7x faster than my efforts to use built-in keywords and large arrays/objects, but it still takes around 300ms on my laptop.