Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when no Plugin#blogkit? method #131

Merged
merged 1 commit into from
Dec 25, 2015
Merged

Conversation

tdtds
Copy link
Member

@tdtds tdtds commented Dec 25, 2015

Plugin#blogkit? メソッドがない場合の対処を入れた

@tdtds tdtds added the bug label Dec 25, 2015
@satoryu
Copy link
Member

satoryu commented Dec 25, 2015

テストが落ちているのがbundler でのインストールが失敗してるのが原因ですね。。。
https://travis-ci.org/tdiary/tdiary-contrib/jobs/98741324#L243-L251

@tdtds
Copy link
Member Author

tdtds commented Dec 25, 2015

これ、どうしたらいいんでしょうね……2.0.0だけいつも成功してるんだけど

@satoryu
Copy link
Member

satoryu commented Dec 25, 2015

Travis がインストールしてるbundlerのバージョンが良くないっぽいですね。
spotify/rspec-dns#26

対処してるコミットを見たら、otahi/rspec-dns@4aa984d
.travis.yml

before_install:
  - gem update bundler

で回避してるようです。

@tdtds
Copy link
Member Author

tdtds commented Dec 25, 2015

なるほどー。じゃあそのPRを作ってみるか。

@tdtds
Copy link
Member Author

tdtds commented Dec 25, 2015

それでいけたっぽいので(#132)、こちらもmergeします。thanks!

tdtds added a commit that referenced this pull request Dec 25, 2015
fix error when no Plugin#blogkit? method
@tdtds tdtds merged commit b3230f0 into master Dec 25, 2015
@tdtds tdtds deleted the fix/no_blogkit_method branch December 25, 2015 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants