Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: crop image flow #1045

Merged
merged 6 commits into from
Nov 1, 2024
Merged

refactor: crop image flow #1045

merged 6 commits into from
Nov 1, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Oct 31, 2024

No description provided.

@boris-w boris-w requested a review from tea-artist October 31, 2024 08:23
@boris-w boris-w force-pushed the refactor/crop-image-flow branch from 4568d51 to eb91039 Compare October 31, 2024 10:08
});
}
await prisma.attachmentsTable.create({
data: omit(newAttachments[i]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omit nothing?

@boris-w boris-w merged commit 999bf3c into develop Nov 1, 2024
7 checks passed
@boris-w boris-w deleted the refactor/crop-image-flow branch November 1, 2024 03:05
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11623464829

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 236 of 314 (75.16%) changed or added relevant lines in 18 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 84.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/attachments/plugins/s3.ts 0 1 0.0%
apps/nestjs-backend/src/features/attachments/attachments-crop.processor.ts 57 60 95.0%
apps/nestjs-backend/src/features/setting/admin.controller.ts 3 6 50.0%
apps/nestjs-backend/src/event-emitter/event-job/fallback/local-queue.provider.ts 1 5 20.0%
apps/nestjs-backend/src/features/record/record.service.ts 62 67 92.54%
apps/nestjs-backend/src/features/attachments/attachments-storage.service.ts 23 31 74.19%
apps/nestjs-backend/src/features/record/typecast.validate.ts 24 38 63.16%
apps/nestjs-backend/src/features/setting/admin.service.ts 14 54 25.93%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/record/record.service.ts 1 89.41%
Totals Coverage Status
Change from base Build 11608889298: -0.09%
Covered Lines: 38656
Relevant Lines: 45751

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants