Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forgot password and setup new password #452

Merged
merged 5 commits into from
Mar 18, 2024
Merged

feat: forgot password and setup new password #452

merged 5 commits into from
Mar 18, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Mar 15, 2024 •
edited
Loading

  • Forgot your password to reset it.
  • Add a new password for registering with a non-account password.

@boris-w boris-w requested a review from tea-artist March 15, 2024 06:45
caoxing9
caoxing9 reviewed Mar 15, 2024
View reviewed changes
apps/nextjs-app/src/features/app/components/setting/account/AddPassword.tsx
});

useEffect(() => {
if (newPassword && confirmPassword && newPassword !== confirmPassword) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my sight, it's better to use different error tip to distinguish when newPassword or confirmPassword is empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, differentiating error messages for newPassword and confirmPassword when they are empty would be beneficial. However, it's not important, I don't want to spend time on it right now.

@boris-w boris-w merged commit d6dc63b into develop Mar 18, 2024
5 checks passed
@boris-w boris-w deleted the feat/password-enhancement branch March 18, 2024 03:30
tea-artist added a commit that referenced this pull request Mar 20, 2024
@tea-artist @caoxing9
@boris-w @dammy001 @MichaelYuhe @Pengap @codesmith-emmy @zzjin @eltociear
release: v1.1.0-beta (#475)
9b9a2cf 
* feat: support excel import (#431)

* feat: support `csv` import

* perf: optimise import memory expend

* fix: `openapi` upload type error

* test: compatible ci attachment download

* feat: add import file icon

* feat: support `excel` import

feat: limit excel file size

refactor: rewrite import font-end

* chore: add `sheetjs` license

* feat: update import url validate strategy

* test: add excel import e2e

* feat: add logger in import records

* fix: type and lint error

* chore: replace axios to node-fetch in nestjs

* test: update import-table e2e

* test: update import-table delay time

* chore: delete `sheetjs` license

* feat: add analyze loading

* chore: export upload-panel component

* feat: integrate github login (#432)

* feat: integrate gitHub login

* feat: dynamic social auth module

* feat: add github auth env validation

* chore: remove electron (#438)

* feat: credit check (#436)

* feat: credit check

* test: exceed credit limit

* refactor: more appropriate email template structure (#437)

* chore: make pnpm automatically install the specified version of Node.js (#433)

* chore: remove nvm step

* fix: the error of copying and pasting empty content (#443)

* fix: the error of copying and pasting empty content

* ci: fixed node version

* ci: pnpm newline handling

* feat: compatible `tsv` import (#446)

* fix: rename link results in illegal data (#448)

* fix: unexpected horizontal lines on login page (#447)

* test: import test file save in tmp dir (#449)

* docs: add deploy on Zeabur in Readme (#451)

* docs: add deploy on Zeabur in Readme

* Update README.md

* Update README.md

* build:  image support `multi-platforms` & app image support `csp-open` (#445)

* build: app image support `csp-open`

* feat: docker image multi-platforms support

* fix: allow default db address (#461)

* feat: forgot password and setup new password (#452)

* feat: forgot password and setup new password

* chore: remove useless code

* fix: use instance test context creator

* fix: type error

* fix: sdk build config for *.spec.tsx

* fix: execute repeat when import upload (#464)

* fix: notify jump url & upgrade deps (#465)

* fix: notify jump url & upgrade deps

* feat: update `PUBLIC_DATABASE_PROXY` env

* fix: ensure interface-provided 'orderBy' parameter overrides view's default sort (#463)

* fix: ensure interface-provided 'orderBy' parameter overrides view's default sort

* fix: existence of identical fields sorted, with the later overwriting the earlier

* chore: signin error alerts

* feat: support google oatuh2 (#466)

* refactor: api for adjusting the order (#453)

* fix: i18n

* docs: star distribution

* refactor: view order

* refactor: view+table+base updateOrder

* feat: ci add `coverallsapp/github-action` (#468)

* feat: ci add `coverallsapp/github-action`

* fix: vitest `coverage.reporter` config (#469)

* fix: vitest `coverage.reporter` config

* chore(example): update dockers examples (#474)

* docs: Update header titles for consistency (#455)

* docs: add one-click deploy on sealos. (#462)

Signed-off-by: zzjin <[email protected]>

* chore: Update constants.ts (#457)

minor fix

* refactor: row order (#473)

* refactor: row order

* fix: sqlite test

---------

Signed-off-by: zzjin <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: Boris <[email protected]>
Co-authored-by: Anjorin Damilare <[email protected]>
Co-authored-by: Yuhang <[email protected]>
Co-authored-by: Pengap <[email protected]>
Co-authored-by: emmanuel <[email protected]>
Co-authored-by: zzjin <[email protected]>
Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caoxing9 caoxing9 caoxing9 left review comments

@tea-artist tea-artist Awaiting requested review from tea-artist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boris-w @caoxing9