refactor: user and link selector #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boris-w
force-pushed
the
fix/share-user-and-link-select
branch
from
4d381fb to
9d7bbc6
Compare
Pull Request Test Coverage Report for Build 8587764926Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
tea-artist
approved these changes
Apr 7, 2024
| async getFilterLinkRecords(tableId: string, viewId: string) { | ||
| const view = await this.viewService.getViewById(viewId); | ||
| const linkFields = await this.prismaService.field.findMany({ | ||
| where: { tableId, deletedTime: null, type: FieldType.Link, options: { not: null } }, |
There was a problem hiding this comment.
options: { not: null } is unnecessary
Sky-FE
approved these changes
Apr 7, 2024
|
|
||
| const fields = await this.fieldService.getFieldsByQuery(tableId, { | ||
| viewId: view.id, | ||
| filterHidden: !view.shareMeta?.includeHiddenField, |
There was a problem hiding this comment.
For the share view of a form, there is no includeHiddenField property, so there's no need to pass in the filterHidden attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose is to get only the data necessary for the user and link selectors in the share view, and is an action to protect data security.
Under the Share page:
relationshipisoneOne, then the associated table records that have already been selected cannot be selected again, so the returned records should be filtered out of the associated records that have already been selected.Of the other views, only the filter component currently requires a data source.