Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Kanban view #528

Merged
merged 20 commits into from
Apr 8, 2024
Merged

feat: Kanban view #528

merged 20 commits into from
Apr 8, 2024

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Apr 3, 2024

No description provided.

@Sky-FE Sky-FE marked this pull request as draft April 3, 2024 07:21
@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2024

Pull Request Test Coverage Report for Build 8597595220

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 35 of 50 (70.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+61.6%) to 82.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts 4 11 36.36%
apps/nestjs-backend/src/utils/get-field-hidden-filter.ts 13 21 61.9%
Totals Coverage Status
Change from base Build 8589235920: 61.6%
Covered Lines: 26989
Relevant Lines: 32592

💛 - Coveralls

@Sky-FE Sky-FE marked this pull request as ready for review April 8, 2024 05:23
export const UserTag = (props: IUserTagProps) => {
const { className, name, avatar, readonly, onDelete } = props;
export const UserTag = (props: IUserTag) => {
const { name = 'Untitled', avatar, suffix, className } = props;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need i18n for 'Untitled'

>
<Layers className="size-4 text-sm" />
</ToolBarButton>
<Filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing components for link and user in share toolbar filter

</ToolBarButton>
)}
</VisibleFields>
<Filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing context for link

@Sky-FE Sky-FE merged commit 04c4b55 into develop Apr 8, 2024
7 of 8 checks passed
@Sky-FE Sky-FE deleted the feat/kanban branch April 8, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants