Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: socket permission #561

Merged
merged 5 commits into from
Apr 12, 2024
Merged

refactor: socket permission #561

merged 5 commits into from
Apr 12, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Apr 10, 2024

No description provided.

@boris-w boris-w changed the title Refactor/socket permission refactor: socket permission Apr 10, 2024
@boris-w boris-w force-pushed the refactor/socket-permisison branch from 71ebc03 to 2ea3da5 Compare April 10, 2024 10:50
@coveralls
Copy link
Collaborator

coveralls commented Apr 10, 2024

Pull Request Test Coverage Report for Build 8656579065

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 20.391%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk/src/context/app/useConnection.tsx 0 1 0.0%
packages/core/src/errors/http/http-response.types.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 8628661395: 0.001%
Covered Lines: 14619
Relevant Lines: 71692

💛 - Coveralls

},
});

const fields = fieldsPlain.map((field) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless code

@boris-w boris-w merged commit f2bb5ef into develop Apr 12, 2024
6 of 8 checks passed
@boris-w boris-w deleted the refactor/socket-permisison branch April 12, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants