-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: group by date field #563
Conversation
Pull Request Test Coverage Report for Build 8699066591Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
||
const { isDistinct } = this.extra ?? {}; | ||
const { dbFieldName } = field; | ||
const column = this.knex.raw(`CAST(?? as text)`, [dbFieldName]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't simply cast JSON to a string.
Here is an example
if you have two multiple-date cells formatted as 'YYYY-MM-DD'
["2024-04-12T00:00:00.000Z"]
["2024-04-12T11:11:11.000Z"]
it should also be distinct as the same group
You should follow the code in search query implementation where correct parsing and matching of multi-valued fields is implemented, they have a similar logic
No description provided.