Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support email invitation for unregistered users #637

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented May 31, 2024

Use the user's password and account to determine whether to register or not.
Registered: Password has been set or account already exists (created by social login).
Unregistered: No user exists, or no password exists and no account exists.

@boris-w boris-w force-pushed the feat/enhance-email-invitation branch from bb7f449 to 417bcc1 Compare May 31, 2024 04:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9314269282

Details

  • 45 of 68 (66.18%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.7%) to 82.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/auth/strategies/github.strategy.ts 0 3 0.0%
apps/nestjs-backend/src/features/auth/strategies/google.strategy.ts 0 3 0.0%
apps/nestjs-backend/src/features/invitation/invitation.service.ts 16 19 84.21%
apps/nestjs-backend/src/features/auth/auth.service.ts 6 20 30.0%
Totals Coverage Status
Change from base Build 9301169849: 63.7%
Covered Lines: 26053
Relevant Lines: 31576

💛 - Coveralls

@boris-w boris-w requested a review from tea-artist May 31, 2024 07:18
@boris-w boris-w merged commit 51b456f into develop Jun 3, 2024
6 checks passed
@boris-w boris-w deleted the feat/enhance-email-invitation branch June 3, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants