Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add forbidden page #649

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: add forbidden page #649

merged 2 commits into from
Jun 6, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Jun 6, 2024

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9396229265

Details

  • 13 of 62 (20.97%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 18.725%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nextjs-app/src/lib/withAuthSSR.ts 0 8 0.0%
apps/nextjs-app/src/features/system/pages/ForbiddenPage.tsx 12 32 37.5%
apps/nextjs-app/src/pages/403.tsx 0 21 0.0%
Totals Coverage Status
Change from base Build 9395946039: 0.002%
Covered Lines: 13866
Relevant Lines: 74050
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9396229264

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.8%) to 82.505%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/next/next.controller.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 9395946039: 63.8%
Covered Lines: 26042
Relevant Lines: 31564
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9396262475

Details

  • 13 of 62 (20.97%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 18.725%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nextjs-app/src/lib/withAuthSSR.ts 0 8 0.0%
apps/nextjs-app/src/features/system/pages/ForbiddenPage.tsx 12 32 37.5%
apps/nextjs-app/src/pages/403.tsx 0 21 0.0%
Totals Coverage Status
Change from base Build 9395946039: 0.002%
Covered Lines: 13866
Relevant Lines: 74050
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9396262478

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.8%) to 82.505%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/next/next.controller.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 9395946039: 63.8%
Covered Lines: 26042
Relevant Lines: 31564
💛 - Coveralls

@boris-w boris-w requested a review from tea-artist June 6, 2024 07:03
@boris-w boris-w merged commit b24f97a into develop Jun 6, 2024
8 checks passed
@boris-w boris-w deleted the feat/forbidden-page branch June 6, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boris-w @coveralls @tea-artist