fix: filtering and grouping collapsed #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 6, 2024
Pull Request Test Coverage Report for Build 9400395331Details
💛 - Coveralls |
tea-artist
requested changes
Jun 6, 2024
| @@ -182,6 +182,7 @@ export abstract class AbstractFilterQuery implements IFilterQueryInterface { | |||
| return ( | |||
| value !== null || | |||
| field.type === FieldType.Checkbox || | |||
| (field.type === FieldType.Formula && field.cellValueType === CellValueType.Boolean) || | |||
There was a problem hiding this comment.
why not simplify just field.cellValueType === CellValueType.Boolean
There was a problem hiding this comment.
what will happen when field.isMultipleCellvalue = true
There was a problem hiding this comment.
When isMultipleCellValue is true, it will perform the filtering operation for the multiple boolean values
caoxing9
approved these changes
Jun 7, 2024
boris-w
approved these changes
Jun 7, 2024
Pull Request Test Coverage Report for Build 9412497445Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9412497433Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9459521902Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9459521906Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.