Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: selecting deleted records in a grid view using a selection api #656

Merged
merged 3 commits into from
Jun 11, 2024
Merged

refactor: selecting deleted records in a grid view using a selection api #656

merged 3 commits into from
Jun 11, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Jun 7, 2024

No description provided.

@boris-w boris-w requested review from Sky-FE and tea-artist June 7, 2024 08:07
@boris-w boris-w linked an issue Jun 7, 2024 that may be closed by this pull request
[Bug] Deleting selected rows deletes only first continuous series of selected rows #651
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9413755400

Details

  • 0 of 108 (0.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 18.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/openapi/src/selection/index.ts 0 1 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/components/RecordMenu.tsx 0 11 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBase.tsx 0 15 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/hooks/useSelectionOperation.ts 0 28 0.0%
packages/openapi/src/selection/delete.ts 0 53 0.0%
Files with Coverage Reduction New Missed Lines %
apps/nextjs-app/src/features/app/blocks/view/grid/hooks/useSelectionOperation.ts 1 0.0%
Totals Coverage Status
Change from base Build 9412542933: -0.02%
Covered Lines: 13866
Relevant Lines: 74148
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9413755501

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.9%) to 82.594%
Totals Coverage Status
Change from base Build 9412542933: 63.9%
Covered Lines: 26084
Relevant Lines: 31581
💛 - Coveralls

Sky-FE
Sky-FE reviewed Jun 7, 2024
View reviewed changes
apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBase.tsx Outdated
@@ -287,11 +289,20 @@ export const GridViewBase: React.FC<IGridViewProps> = (props: IGridViewProps) =>
neighborRecords[1] = rowStart >= realRowCount - 1 ? null : recordMap[rowStart + 1];
}

const selectedRecordCount = isCellSelection
? rowEnd - rowStart + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rowStart and rowEnd denote the start and end rows of a selection, with rowStart possibly exceeding rowEnd

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9459456599

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 129 (0.0%) changed or added relevant lines in 5 files are covered.
  • 17 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.03%) to 18.697%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/openapi/src/selection/index.ts 0 1 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/components/RecordMenu.tsx 0 14 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/hooks/useSelectionOperation.ts 0 28 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBase.tsx 0 33 0.0%
packages/openapi/src/selection/delete.ts 0 53 0.0%
Files with Coverage Reduction New Missed Lines %
apps/nextjs-app/src/features/app/blocks/view/grid/hooks/useSelectionOperation.ts 1 0.0%
packages/sdk/src/components/filter/condition/OperatorSelect.tsx 1 0.0%
packages/sdk/src/components/filter/condition/Condition.tsx 4 0.0%
packages/sdk/src/components/filter/types/types.ts 4 0.0%
packages/sdk/src/components/filter/FilterMain.tsx 7 0.0%
Totals Coverage Status
Change from base Build 9412542933: -0.03%
Covered Lines: 13866
Relevant Lines: 74161
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9459456600

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.9%) to 82.594%
Totals Coverage Status
Change from base Build 9412542933: 63.9%
Covered Lines: 26084
Relevant Lines: 31581
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9459492384

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 130 (0.0%) changed or added relevant lines in 5 files are covered.
  • 17 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.03%) to 18.697%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/openapi/src/selection/index.ts 0 1 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/components/RecordMenu.tsx 0 14 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/hooks/useSelectionOperation.ts 0 28 0.0%
apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBase.tsx 0 34 0.0%
packages/openapi/src/selection/delete.ts 0 53 0.0%
Files with Coverage Reduction New Missed Lines %
apps/nextjs-app/src/features/app/blocks/view/grid/hooks/useSelectionOperation.ts 1 0.0%
packages/sdk/src/components/filter/condition/OperatorSelect.tsx 1 0.0%
packages/sdk/src/components/filter/condition/Condition.tsx 4 0.0%
packages/sdk/src/components/filter/types/types.ts 4 0.0%
packages/sdk/src/components/filter/FilterMain.tsx 7 0.0%
Totals Coverage Status
Change from base Build 9412542933: -0.03%
Covered Lines: 13866
Relevant Lines: 74161
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9459492387

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.9%) to 82.594%
Totals Coverage Status
Change from base Build 9412542933: 63.9%
Covered Lines: 26084
Relevant Lines: 31581
💛 - Coveralls

@boris-w boris-w merged commit a30bdf6 into develop Jun 11, 2024
8 checks passed
@boris-w boris-w deleted the refactor/grid-delete-record branch June 11, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sky-FE Sky-FE Sky-FE approved these changes

@tea-artist tea-artist Awaiting requested review from tea-artist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Deleting selected rows deletes only first continuous series of selected rows
3 participants
@boris-w @coveralls @Sky-FE