Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto replace storage prefix #670

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: auto replace storage prefix #670

merged 1 commit into from
Jun 20, 2024

Conversation

tea-artist
Copy link
Contributor

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9595089046

Details

  • 2 of 50 (4.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 18.682%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/utils/replace-suffix.ts 1 11 9.09%
apps/nextjs-app/src/features/app/hooks/usePreviewUrl.ts 0 12 0.0%
apps/nextjs-app/src/features/app/blocks/view/form/components/FormEditorMain.tsx 0 13 0.0%
apps/nextjs-app/src/features/app/blocks/view/form/components/FormPreviewer.tsx 0 13 0.0%
Totals Coverage Status
Change from base Build 9592419759: -0.007%
Covered Lines: 13868
Relevant Lines: 74230

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9595089053

Details

  • 7 of 20 (35.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+64.0%) to 82.698%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/utils/full-storage-url.ts 6 8 75.0%
apps/nestjs-backend/src/features/attachments/plugins/minio.ts 1 12 8.33%
Totals Coverage Status
Change from base Build 9592419759: 64.0%
Covered Lines: 26150
Relevant Lines: 31621

💛 - Coveralls

@tea-artist tea-artist merged commit 0735c1c into develop Jun 20, 2024
8 checks passed
@tea-artist tea-artist deleted the fix/suffix branch June 20, 2024 09:42
@tea-artist tea-artist restored the fix/suffix branch January 2, 2025 12:11
@tea-artist tea-artist deleted the fix/suffix branch January 2, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants