Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: attachment remove bucket #715

Merged
merged 7 commits into from
Jul 13, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Jul 12, 2024

  • remove bucket from attachment table
  • remove bucket part from avatar
  • remove bucket part from form coverUrl and logoUrl
  • full coverUrl and logo Url on get form view endpoint
  • migration form view type key "Form" to "form"

@boris-w boris-w requested review from Sky-FE and tea-artist July 12, 2024 08:27
@boris-w boris-w marked this pull request as ready for review July 12, 2024 08:27
@coveralls
Copy link
Collaborator

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9906432951

Details

  • 99 of 123 (80.49%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+64.1%) to 82.059%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/attachments/plugins/local.ts 6 7 85.71%
apps/nestjs-backend/src/features/field/model/field-base.ts 0 1 0.0%
apps/nestjs-backend/src/features/attachments/attachments-storage.service.ts 1 3 33.33%
apps/nestjs-backend/src/features/attachments/plugins/minio.ts 0 2 0.0%
apps/nestjs-backend/src/features/attachments/plugins/utils.ts 11 13 84.62%
apps/nestjs-backend/src/features/attachments/plugins/s3.ts 0 4 0.0%
apps/nestjs-backend/src/features/notification/notification.service.ts 8 13 61.54%
apps/nestjs-backend/src/features/user/user.service.ts 6 13 46.15%
Totals Coverage Status
Change from base Build 9901584181: 64.1%
Covered Lines: 27626
Relevant Lines: 33666

💛 - Coveralls

@tea-artist tea-artist merged commit 5ce5a92 into develop Jul 13, 2024
8 checks passed
@tea-artist tea-artist deleted the refactor/attachment-remove-bucket branch July 13, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import CSV or Excel files Internal server error show when create a new table from csv file
3 participants