Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: field validation #731

Merged
merged 6 commits into from
Jul 18, 2024
Merged

feat: field validation #731

merged 6 commits into from
Jul 18, 2024

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Jul 17, 2024

No description provided.

@Sky-FE Sky-FE marked this pull request as draft July 17, 2024 11:56
@coveralls
Copy link
Collaborator

coveralls commented Jul 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9985260934

Details

  • 140 of 166 (84.34%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+65.4%) to 83.267%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/field/field.service.ts 74 76 97.37%
apps/nestjs-backend/src/features/field/field-calculate/field-converting.service.ts 3 27 11.11%
Totals Coverage Status
Change from base Build 9971882516: 65.4%
Covered Lines: 28230
Relevant Lines: 33903
💛 - Coveralls

@Sky-FE Sky-FE marked this pull request as ready for review July 18, 2024 03:56
@Sky-FE Sky-FE requested a review from tea-artist July 18, 2024 03:56
@Sky-FE Sky-FE merged commit 1f45bac into develop Jul 18, 2024
8 checks passed
@Sky-FE Sky-FE deleted the feat/unique-value branch July 18, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sky-FE @coveralls @tea-artist