Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjusting the base sidebar option permission display control #737

Merged
merged 3 commits into from
Jul 22, 2024
Merged

chore: adjusting the base sidebar option permission display control #737

merged 3 commits into from
Jul 22, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Jul 19, 2024

No description provided.

@boris-w boris-w requested a review from tea-artist July 19, 2024 11:03
@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10007613097

Details

  • 11 of 21 (52.38%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+65.3%) to 83.322%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/base/base.service.ts 3 5 60.0%
apps/nestjs-backend/src/features/table/open-api/table-open-api.service.ts 2 4 50.0%
apps/nestjs-backend/src/features/table/table-permission.service.ts 3 9 33.33%
Totals Coverage Status
Change from base Build 9993707628: 65.3%
Covered Lines: 28312
Relevant Lines: 33979
💛 - Coveralls

@tea-artist tea-artist merged commit 0a0bf44 into develop Jul 22, 2024
8 checks passed
@tea-artist tea-artist deleted the chore/base-sidebar-permission branch July 22, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boris-w @coveralls @tea-artist