Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the grid rendering issues during collaboration #765

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: the grid rendering issues during collaboration #765

merged 1 commit into from
Jul 26, 2024

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Jul 26, 2024

No description provided.

@Sky-FE Sky-FE requested review from caoxing9 and tea-artist July 26, 2024 08:51
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10108515410

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 17.744%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk/src/components/grid/renderers/layout-renderer/layoutRenderer.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10107139991: 0.001%
Covered Lines: 14038
Relevant Lines: 79114
💛 - Coveralls

caoxing9
caoxing9 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@caoxing9 caoxing9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sky-FE Sky-FE merged commit 2103750 into develop Jul 26, 2024
5 checks passed
@Sky-FE Sky-FE deleted the fix/grid-render-error branch July 26, 2024 11:15
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
@Sky-FE @AliceLanniste
fix: the grid rendering issues during collaboration (teableio#765)
d93ad36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

@caoxing9 caoxing9 caoxing9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sky-FE @coveralls @caoxing9 @tea-artist