Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict the encoding format of attachment names to utf-8 #802

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: restrict the encoding format of attachment names to utf-8 #802

merged 1 commit into from
Aug 8, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Aug 8, 2024

No description provided.

@boris-w boris-w requested a review from caoxing9 August 8, 2024 06:53
@boris-w boris-w merged commit 616efc5 into develop Aug 8, 2024
5 checks passed
@boris-w boris-w deleted the fix/attachment-filename-encode branch August 8, 2024 07:06
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10297377414

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+64.3%) to 81.982%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/attachments/attachments.controller.ts 7 10 70.0%
Totals Coverage Status
Change from base Build 10281265357: 64.3%
Covered Lines: 28269
Relevant Lines: 34482
💛 - Coveralls

AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
@boris-w @AliceLanniste
fix: restrict the encoding format of attachment names to utf-8 (teabl…
92edcc5 
…eio#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

@caoxing9 caoxing9 Awaiting requested review from caoxing9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boris-w @coveralls @tea-artist