Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the attachments rendering in the record history #806

Merged
merged 3 commits into from
Aug 9, 2024
Merged

fix: the attachments rendering in the record history #806

merged 3 commits into from
Aug 9, 2024

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Aug 9, 2024

No description provided.

@Sky-FE Sky-FE requested review from boris-w and tea-artist August 9, 2024 07:01
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10315078073

Details

  • 76 of 83 (91.57%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 82.673%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts 42 49 85.71%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts 1 92.41%
Totals Coverage Status
Change from base Build 10314531654: -0.002%
Covered Lines: 29324
Relevant Lines: 35470
💛 - Coveralls

@Sky-FE Sky-FE merged commit c91ec08 into develop Aug 9, 2024
7 checks passed
@Sky-FE Sky-FE deleted the fix/record-history branch August 9, 2024 07:15
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
@Sky-FE @AliceLanniste
fix: the attachments rendering in the record history (teableio#806)
f7ebd96 
* fix: the attachment rendering in the history record

* perf: attachments in the record history support preview and download

* fix: column constraints are automatically inherited during field conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

@boris-w boris-w Awaiting requested review from boris-w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sky-FE @coveralls @tea-artist