Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reconstruct filter with abstract #818

Merged
merged 8 commits into from
Aug 17, 2024
Merged

Conversation

caoxing9
Copy link
Contributor

@caoxing9 caoxing9 commented Aug 13, 2024

feat: abstract compatible base filter
feat: delete view relative view condition(filter,sort,group etc) when update/delete field
feat: display delete tips when filter item has been deleted
feat: filter style adjust and unified

@caoxing9 caoxing9 marked this pull request as draft August 13, 2024 08:27
@caoxing9 caoxing9 force-pushed the refactory/filter branch 3 times, most recently from fa3644d to b3a565c Compare August 13, 2024 10:35
@caoxing9 caoxing9 requested a review from boris-w August 13, 2024 11:26
@caoxing9 caoxing9 force-pushed the refactory/filter branch 2 times, most recently from 33c7ffb to 8666c48 Compare August 15, 2024 07:13
@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 10432127947

Details

  • 155 of 304 (50.99%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 82.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/view/view.service.ts 48 113 42.48%
apps/nestjs-backend/src/features/field/field-calculate/field-converting.service.ts 99 183 54.1%
Totals Coverage Status
Change from base Build 10417797275: -0.3%
Covered Lines: 30092
Relevant Lines: 36308

💛 - Coveralls

@caoxing9 caoxing9 marked this pull request as ready for review August 15, 2024 11:09
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

@caoxing9 caoxing9 merged commit 6df36f3 into develop Aug 17, 2024
6 of 8 checks passed
@caoxing9 caoxing9 deleted the refactory/filter branch August 17, 2024 12:34
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
* refactor: reconstruct filter with abstract

* chore: rebase the dev branch

* fix: lint error

* perf: update filter `UserSelect` style

* fix: update field check repeat request

* feat: delete view relative data when delete field

* feat: deal view filter when update field info

* feat: add maxDepth limit in base filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants