-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete record in edit header #828
Merged
tea-artist
merged 7 commits into
teableio:develop
from
spiritanand:feat/delete-record-in-edit-header
Aug 16, 2024
Merged
feat: delete record in edit header #828
tea-artist
merged 7 commits into
teableio:develop
from
spiritanand:feat/delete-record-in-edit-header
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiritanand
changed the title
[Draft] Feat: Delete record in edit header
Feat: Delete record in edit header
Aug 15, 2024
@tea-artist feature has been implemented, authorized users can now delete records from edit menu |
tea-artist
reviewed
Aug 16, 2024
apps/nextjs-app/src/features/app/components/ExpandRecordContainer/ExpandRecordContainerBase.tsx
Outdated
Show resolved
Hide resolved
packages/sdk/src/components/expand-record/ExpandRecordHeader.tsx
Outdated
Show resolved
Hide resolved
tea-artist
requested review from
Sky-FE and
boris-w
and removed request for
Sky-FE
August 16, 2024 03:12
Checklist:
|
tea-artist
changed the title
Feat: Delete record in edit header
feat: delete record in edit header
Aug 16, 2024
boris-w
reviewed
Aug 16, 2024
packages/sdk/src/components/expand-record/ExpandRecordHeader.tsx
Outdated
Show resolved
Hide resolved
boris-w
reviewed
Aug 16, 2024
@tea-artist @boris-w users can now delete using the |
tea-artist
approved these changes
Aug 16, 2024
boris-w
approved these changes
Aug 16, 2024
AliceLanniste
pushed a commit
to AliceLanniste/teable
that referenced
this pull request
Sep 1, 2024
* feat: create ellipsis icon * feat: ui for dropdown menu and button to delete record * feat: make delete button uniform * feat: handle delete of selected record * refactor: replace ellipsis with more-horizontal icon * feat: delete record using API * translation: new key for deleting record in expand edit record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #668
UI
Desktop
Mobile