Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: base collaborator #837

Merged
merged 9 commits into from
Aug 20, 2024
Merged

feat: base collaborator #837

merged 9 commits into from
Aug 20, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented Aug 16, 2024

  • manage all base shared
  • test migration
  • test Invited user role restrictions
  • test update collaborator user role restrictions
  • test detele collaborator user role restrictions
  • All of the above are based on base and space
  • when the user is already inside the base and then operates the invitation to enter space, it should be directly upgraded to space collaborator

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

@boris-w boris-w requested review from tea-artist and Sky-FE August 19, 2024 09:11
@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10465283539

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 655 of 741 (88.39%) changed or added relevant lines in 13 files are covered.
  • 266 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 83.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/auth/permission.service.ts 10 11 90.91%
apps/nestjs-backend/src/features/table/table-permission.service.ts 0 1 0.0%
apps/nestjs-backend/src/features/base/base.controller.ts 116 119 97.48%
apps/nestjs-backend/src/features/invitation/invitation.service.ts 230 243 94.65%
apps/nestjs-backend/src/features/base/base.service.ts 2 29 6.9%
apps/nestjs-backend/src/features/collaborator/collaborator.service.ts 208 249 83.53%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/field/open-api/field-open-api.service.ts 1 63.08%
apps/nestjs-backend/src/features/view/view.service.ts 87 77.43%
apps/nestjs-backend/src/features/field/field-calculate/field-converting.service.ts 178 80.13%
Totals Coverage Status
Change from base Build 10417797275: -0.1%
Covered Lines: 30551
Relevant Lines: 36801

💛 - Coveralls

@@ -22,7 +22,7 @@ STORAGE_PREFIX=http://127.0.0.1:3000

# DATABASE_URL
# @see https://www.prisma.io/docs/reference/database-reference/connection-urls#examples
PRISMA_DATABASE_URL=postgresql://teable:[email protected]:5432/teable?schema=public&statement_cache_size=1
PRISMA_DATABASE_URL=file:../../db/main.db
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change this

@boris-w boris-w merged commit ecb1fa2 into develop Aug 20, 2024
8 checks passed
@boris-w boris-w deleted the feat/base-collaborator branch August 20, 2024 06:32
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
* feat: base collaborator

* feat: shared base page

* fix: shared base grid

* test: add space and base collaborator e2e

* feat: user-name listener support base collaborator

* fix: invitation service unit tests

* fix: collaborator service unit tests

* fix: collaborator migration

* chore: restore env changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants