-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base collaborator #837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boris-w
commented
Aug 16, 2024
•
edited
Loading
edited
- manage all base shared
- test migration
- test Invited user role restrictions
- test update collaborator user role restrictions
- test detele collaborator user role restrictions
- All of the above are based on base and space
- when the user is already inside the base and then operates the invitation to enter space, it should be directly upgraded to space collaborator
Pull Request Test Coverage Report for Build 10465283539Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
tea-artist
approved these changes
Aug 20, 2024
apps/nextjs-app/.env.development
Outdated
@@ -22,7 +22,7 @@ STORAGE_PREFIX=http://127.0.0.1:3000 | |||
|
|||
# DATABASE_URL | |||
# @see https://www.prisma.io/docs/reference/database-reference/connection-urls#examples | |||
PRISMA_DATABASE_URL=postgresql://teable:[email protected]:5432/teable?schema=public&statement_cache_size=1 | |||
PRISMA_DATABASE_URL=file:../../db/main.db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't change this
AliceLanniste
pushed a commit
to AliceLanniste/teable
that referenced
this pull request
Sep 1, 2024
* feat: base collaborator * feat: shared base page * fix: shared base grid * test: add space and base collaborator e2e * feat: user-name listener support base collaborator * fix: invitation service unit tests * fix: collaborator service unit tests * fix: collaborator migration * chore: restore env changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.